Spoolman config not included #72
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
First of all, this bugreport is somewhat premature, since the code in question is in master, but has not been released yet. I happened to notice this problem however and hopefully it can be fixed before it becomes an actual bug,
Main issue:
The upcoming spoolman integration depends on 2 settings: a spoolman server and a sync-rate. It the original PR these were part of the config.ini.example files, but in the current master branch these settings are not present, even though the code that uses it is.
Quality of life issue:
It would be nice if these settings could also be configured from the web-ui. This is not really a bug, more a missing feature, so if it's hard to fix as part of this bug, then I'll gladly post it as a feature request after the next release that includes the spoolman integration.
Hi, we're working on some restructuring this week. See the README on the main page. However, your suggestion is already in the current development branch. It will be released soon in the nightly branch.
Amazing, I'll close the bug then
Hi @BasK,
Good catch — and thank you for reporting this before it became an active bug for users.
The
[spoolman]section was present in the dev repository but was not being copied into the release repo during the sync step. Fixed:config/config.ini.examplenow includes the Spoolman config block and the release script has been updated to always sync it going forward.Regarding the Web UI configuration: fully agreed — that is the logical next step. I will open a follow-up for it.