viewit/KX-Bridge-Release
10
17
Fork 10
Code Issues 1 Pull Requests Actions Packages Projects Releases 56 Wiki Activity

fix: self._db did not exist, use self._store #93

Manually merged
viewit merged 1 commits from Pavulon87/KX-Bridge-Release:fix/db-not-exist into nightly 2026-07-16 21:35:59 +02:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
Pavulon87 commented 2026-07-16 15:21:53 +02:00
Contributor
Copy Link

Description

This PR fixes a reference to a non-existent database object when reading filament metadata from a G-code file.

The code was still using self._db, which is no longer present. It has been replaced with self._store, matching the rest of the codebase and restoring the expected behavior.

This is a small consistency fix with no functional changes beyond using the correct storage object.

Related Issue

N/A

Type

  • Bug fix
  • Feature
  • Documentation
  • Refactoring

Tested with

  • OrcaSlicer Version: 2.5.0-dev-kx1
  • Printer: Kobra X
  • Moonraker/Klipper Version:

Checklist

  • Tests added/updated
  • CHANGELOG.md updated
  • No debug code included
## Description This PR fixes a reference to a non-existent database object when reading filament metadata from a G-code file. The code was still using `self._db`, which is no longer present. It has been replaced with `self._store`, matching the rest of the codebase and restoring the expected behavior. This is a small consistency fix with no functional changes beyond using the correct storage object. ## Related Issue N/A ## Type - [X] Bug fix - [ ] Feature - [ ] Documentation - [ ] Refactoring ## Tested with - OrcaSlicer Version: 2.5.0-dev-kx1 - Printer: Kobra X - Moonraker/Klipper Version: ## Checklist - [ ] Tests added/updated - [ ] CHANGELOG.md updated - [X] No debug code included
Pavulon87 added 1 commit 2026-07-16 15:21:54 +02:00
fix: self._db did not exist, use self._store
Some checks failed
Nightly Build / build (push) Has been cancelled
Details
PR Check / lint-and-test (pull_request) Has been cancelled
Details
03089db6af
viewit manually merged commit 03089db6af into nightly 2026-07-16 21:35:59 +02:00
viewit commented 2026-07-16 21:36:12 +02:00
Owner
Copy Link

Merged, thanks @Pavulon87! Good catch — this dated back to an earlier fix of mine that introduced the self._db typo; the try/except around it silently swallowed the resulting AttributeError so it never surfaced in testing.

Merged, thanks @Pavulon87! Good catch — this dated back to an earlier fix of mine that introduced the `self._db` typo; the `try/except` around it silently swallowed the resulting AttributeError so it never surfaced in testing.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
bug
documentation
duplicate
This issue or pull request already exists
enhancement
New feature
enhancement
help wanted
Need some help
invalid
Something is wrong
known-issue
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
viewit
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: viewit/KX-Bridge-Release#93
No description provided.
Delete Branch "Pavulon87/KX-Bridge-Release:fix/db-not-exist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?